From 3c7df908100c7763167a524f69b476bbf8fb8086 Mon Sep 17 00:00:00 2001 From: Dominik Roth Date: Sun, 29 Oct 2023 14:37:30 +0100 Subject: [PATCH 1/4] Ensure we only react to push onto master; disable via if clause --- .github/workflows/publish-to-pypi.yml | 12 ++++++------ .github/workflows/publish-to-test-pypi.yml | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish-to-pypi.yml b/.github/workflows/publish-to-pypi.yml index 09665f3..fb75642 100644 --- a/.github/workflows/publish-to-pypi.yml +++ b/.github/workflows/publish-to-pypi.yml @@ -1,17 +1,17 @@ name: Publish Python package to PyPI on: - # Action currently disabled to only push to TestPyPI for now - - #push: - # tags: - # - '*' + push: + branches: + - master + tags: + - '*' jobs: publish: name: Publish to PyPI runs-on: ubuntu-latest - if: startsWith(github.ref, 'refs/tags/') # Only run on tagged commits + if: false && startsWith(github.ref, 'refs/tags/') # Only run on tagged commits steps: - name: Check out code diff --git a/.github/workflows/publish-to-test-pypi.yml b/.github/workflows/publish-to-test-pypi.yml index b348845..2afd464 100644 --- a/.github/workflows/publish-to-test-pypi.yml +++ b/.github/workflows/publish-to-test-pypi.yml @@ -1,6 +1,8 @@ name: Publish Python package to TestPyPI on: + branches: + - master push: tags: - '*' From 4a9ea368b8ca835d9c38cdb3ef8487c50f23476b Mon Sep 17 00:00:00 2001 From: Dominik Roth Date: Sun, 29 Oct 2023 14:39:02 +0100 Subject: [PATCH 2/4] fix typo in publish-to-test-pypi.yml --- .github/workflows/publish-to-test-pypi.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-to-test-pypi.yml b/.github/workflows/publish-to-test-pypi.yml index 2afd464..8cc98fb 100644 --- a/.github/workflows/publish-to-test-pypi.yml +++ b/.github/workflows/publish-to-test-pypi.yml @@ -1,9 +1,9 @@ name: Publish Python package to TestPyPI on: - branches: - - master push: + branches: + - master tags: - '*' From f02461380050d03fece877128e849a0369eced71 Mon Sep 17 00:00:00 2001 From: Dominik Roth Date: Sun, 29 Oct 2023 16:02:10 +0100 Subject: [PATCH 3/4] Prevent fallback to setup.py when building package --- .github/workflows/publish-to-pypi.yml | 3 +++ .github/workflows/publish-to-test-pypi.yml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/publish-to-pypi.yml b/.github/workflows/publish-to-pypi.yml index fb75642..3747e30 100644 --- a/.github/workflows/publish-to-pypi.yml +++ b/.github/workflows/publish-to-pypi.yml @@ -29,6 +29,9 @@ jobs: build setuptools twine --user + - name: Prevent fallback onto setup.py + run: rm setup.py + - name: Build a binary wheel and a source tarball run: python3 -m build diff --git a/.github/workflows/publish-to-test-pypi.yml b/.github/workflows/publish-to-test-pypi.yml index 8cc98fb..8b8d003 100644 --- a/.github/workflows/publish-to-test-pypi.yml +++ b/.github/workflows/publish-to-test-pypi.yml @@ -29,6 +29,9 @@ jobs: build setuptools twine --user + - name: Prevent fallback onto setup.py + run: rm setup.py + - name: Build a binary wheel and a source tarball run: python3 -m build From bbd964ed80edea8e56b39fe253320b89248ecdf0 Mon Sep 17 00:00:00 2001 From: Dominik Roth Date: Sun, 29 Oct 2023 16:50:02 +0100 Subject: [PATCH 4/4] Use full URLs for links in README (wont work on PyPI otherwise) --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 46c536b..1cedaba 100644 --- a/README.md +++ b/README.md @@ -92,7 +92,7 @@ pip install metaworld@git+https://github.com/Farama-Foundation/Metaworld.git@d15 ## How to use Fancy Gym -We will only show the basics here and prepared [multiple examples](fancy_gym/examples/) for a more detailed look. +We will only show the basics here and prepared [multiple examples](https://github.com/ALRhub/fancy_gym/tree/master/fancy_gym/examples/) for a more detailed look. ### Step-Based Environments @@ -197,7 +197,7 @@ print(fancy_gym.MOVEMENT_PRIMITIVE_ENVIRONMENTS_FOR_NS['']) ### How to create a new MP task In case a required task is not supported yet in the MP framework, it can be created relatively easy. For the task at -hand, the following [interface](fancy_gym/black_box/raw_interface_wrapper.py) needs to be implemented. +hand, the following [interface](https://github.com/ALRhub/fancy_gym/tree/master/fancy_gym/black_box/raw_interface_wrapper.py) needs to be implemented. ```python from abc import abstractmethod @@ -283,7 +283,7 @@ class RawInterfaceWrapper(gym.Wrapper): If you created a new task wrapper, feel free to open a PR, so we can integrate it for others to use as well. Without the integration the task can still be used. A rough outline can be shown here, for more details we recommend having a look -at the [examples](fancy_gym/examples/). +at the [examples](https://github.com/ALRhub/fancy_gym/tree/master/fancy_gym/examples/). If the step-based is already registered with gym, you can simply do the following: