dodox/metastable-baselines
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed: Wrong simplification for Hybrid[SCALAR=>FULL]

Browse Source
This commit is contained in:
Dominik Moritz Roth 2022-07-17 00:47:47 +02:00
parent 046fa78206
commit 49f9acff3e
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
metastable_baselines/distributions/distributions.py
View File

@ -350,8 +350,15 @@ class CholNet(nn.Module):
chol = th.linalg.cholesky(cov) chol = th.linalg.cholesky(cov)
return chol return chol
elif self.par_strength == Strength.SCALAR and self.cov_strength == Strength.FULL: elif self.par_strength == Strength.SCALAR and self.cov_strength == Strength.FULL:
factor = self.factor(x) # TODO: Maybe possible to improve speed and stability by multiplying with factor in cholesky-form.
return self._parameterize_full(self.params * factor[0]) factor = self._ensure_positive_func(self.factor(x))
par_chol = self._parameterize_full(self.params)
cov = (par_chol.T @ par_chol)
if len(factor) > 1:
factor = factor.unsqueeze(2)
cov = cov * factor
chol = th.linalg.cholesky(cov)
return chol
raise Exception() raise Exception()
@property @property