dodox/metastable-baselines2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

clip_fraction calc broken for clip_fraction=None

Browse Source
This commit is contained in:
Dominik Moritz Roth 2024-01-23 11:46:50 +01:00
parent 54b841654b
commit c67f78159b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
metastable_baselines2/trpl/trpl.py
View File

@ -253,9 +253,13 @@ class TRPL(BetterOnPolicyAlgorithm):
# Logging # Logging
pg_losses.append(surrogate_loss.item()) pg_losses.append(surrogate_loss.item())
if self.clip_range is not None:
clip_fraction = th.mean((th.abs(ratio - 1) > clip_range).float()).item() clip_fraction = th.mean((th.abs(ratio - 1) > clip_range).float()).item()
else:
clip_fraction = 0
clip_fractions.append(clip_fraction) clip_fractions.append(clip_fraction)
if self.clip_range_vf is None: if self.clip_range_vf is None:
# No clipping # No clipping
values_pred = values values_pred = values