Fix ally/target bugs, OCR fire-support parsing, add debug capture #1
Assignees
dodox (Dominik Moritz Roth)
Clear assignees
dodox (Dominik Moritz Roth)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: dodox/FEnigma#1
Reference in New Issue
Block a user
allies too. New Board.clear_units() + Clear button right-click menu
("clear enemies, units & flights", keeps Nest/spotters/RPs).
popover/toast instead of "Ally" (icons.target_type_label already had
the fix for the picker, now reused everywhere else via app.py's
_display_name).
(solver + dedupe + map redraw) on every drop, just a local rebuild.
candidate list); blast radius only respected selection, not the
show_geo_desc pin.
taking fire ... Requesting X Shell on our position at before
badly, for later tuning of map_vision/ocr against real failures:
map-read errors, user grid corrections (paired with the auto-detected
grid), screenshots that read as text but may have been a map, and
marker-detection ground truth (every proposal's accept/reject verdict
plus units added with no matching proposal) captured whenever a
screenshot stops being the active one.
detection, is unreliable and fails often).
additions to tests/test_ocr.py), 38/38 passing
- Board.clear() now also drops allies; the "clear board?" guard checks allies too. New Board.clear_units() + Clear button right-click menu ("clear enemies, units & flights", keeps Nest/spotters/RPs). - An Ally with the ad-hoc TargetType.ENEMY showed "Enemy" on the map popover/toast instead of "Ally" (icons.target_type_label already had the fix for the picker, now reused everywhere else via app.py's _display_name). - Firing panel drag-reorder no longer triggers a full app refresh (solver + dedupe + map redraw) on every drop, just a local rebuild. - "Always show geo" didn't draw for Allies (missing from the overlay candidate list); blast radius only respected selection, not the show_geo_desc pin. - ocr.py: added a second fire-support-request grammar ("Infantry#N taking fire ... Requesting X Shell on our position at <coord> before <time>", plus a bearing/distance-from-position variant), distinct from the existing Marine Garrison one. - New debug_capture.py: saves screenshots (+ metadata) the app handled badly, for later tuning of map_vision/ocr against real failures: map-read errors, user grid corrections (paired with the auto-detected grid), screenshots that read as text but may have been a map, and marker-detection ground truth (every proposal's accept/reject verdict plus units added with no matching proposal) captured whenever a screenshot stops being the active one. - README: Known issues section (map screenshot reading, grid + unit detection, is unreliable and fails often). - 14 new tests (tests/test_models.py, tests/test_debug_capture.py, + additions to tests/test_ocr.py), 38/38 passing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>